Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename useImperativeMethods -> useImperativeHandle #1544

Merged
merged 3 commits into from
Jan 15, 2019

Conversation

threepointone
Copy link
Contributor

A followup from facebook/react#14565; don't merge this till we land that one. thanks!

@reactjs-bot
Copy link

reactjs-bot commented Jan 10, 2019

Deploy preview for reactjs ready!

Built with commit 06b08a2

https://deploy-preview-1544--reactjs.netlify.com


```js
useImperativeMethods(ref, createInstance, [inputs])
useImperativeHandle(ref, createInstance, [inputs])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe createHandle

content/docs/hooks-reference.md Show resolved Hide resolved
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gogogo 👍

@gaearon
Copy link
Member

gaearon commented Jan 15, 2019

Should probably merge after a release is out?

@bvaughn bvaughn merged commit 924e76d into reactjs:master Jan 15, 2019
@bvaughn
Copy link
Contributor

bvaughn commented Jan 15, 2019

Since I just published a new alpha, I'm rolling out this change also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants