-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with Crowdin localization project #82
Comments
Happy to help create a Gatsby source plugin for Crowdin! That'd be really powerful. And a lot of people would use it including sooner than later gatsbyjs.org From a bit of research, it looks like it'd be pretty easy to pull data using their API:
I spent a bunch of time adding localization support to https://www.gatsbyjs.org/packages/gatsby-source-contentful/ as well so have some opinions on this. See the example site for Contentful + its source |
Fantastic 😄 There's a good chance we'll end up collaborating on this soon then. |
Netlify also has a way of doing redirects based on
I'd suggest
We have perf issues with the Yarn site, but a lot of it is because we're using Jekyll. Most of the build time is actually the Jekyll build time rather than CrowdIn. We had a prototype using Hugo that was much faster. I don't think CrowdIn takes a significant amount of time there.
Would the React site actually need a custom API integration? It could be useful, but CrowdIn has a CLI tool (https://support.crowdin.com/cli-tool/) which we might be able to use with less effort. For Yarn we just run |
Don't have time to fully digest this response now- but wanted to mention that we should ensure whatever change we make does not break pre-existing links (like how links broke for Jest). |
It doesn't need it but it seems simpler perhaps to just query the data through graphql instead of writing it out first then pulling it in. But yeah, definitely more straightforward to just use the cli. Would you checkin the translated content? |
Jest is limited in what it can do, because it's using GitHub Pages. With Netlify, you can generate some redirects as part of the build. Just need to redirect "raw" URLs ( Check it out with Yarn: https://yarnpkg.com/docs/getting-started redirects to the right place. :)
We don't for Yarn. It's pulled in as part of the build process for the site. Since CrowdIn tracks the history for the translations, we didn't really need to also have Git track it. Some sites do commit the translated files though. Up to you - Either way is fine. |
No |
Cool! 👍 |
Here's how the Yarn site builds all the redirects from non-localized URLs to localized URLs: https://github.com/yarnpkg/website/blob/master/_redirects#L48-L70 (this would also be how you handle your redirects from 'old' URLs to new localized URLs). Unfortunately the Yarn one is super difficult to understand because it's using the Jekyll templating syntax. Somehow @thejameskyle got it working though. You could likely make a nicer JS script to do the same thing for the React site. The resulting redirects file looks something like this:
Here's the entire language redirects section: https://gist.github.com/Daniel15/d84b39e8a260ee2a7d627751d015181b Docs: https://www.netlify.com/docs/redirects/#geoip-and-language-based-redirects Might be able to use a regex or placeholders or something rather than having to generate all the redirects like that. |
@bvaughn wrote a nice redirect API for Gatsby + added it to gatsby-plugin-netlify so this setting up redirects would be pretty easy :-) |
Hi, the official doc in English is being updated frequently, but the contents in Crowdin seems to be out of sync with the newest doc. I think it's still based on the doc several months ago, and I'm seeing no doc for error boundaries ready for translation. I'm new to Crowdin, but I want to believe there is a way to merge the updates in the original doc and enable people to translate the changed part incrementally. Is there any plan for this? I'd rather not see an overwhelming one-time update of the original doc. |
Crowdin docs show support in their REST API to add, update, and delete a file- so it seems plausible that we could write a script to automatically sync english content from GitHub to Crowdin. Maybe we could even use CircleCI to run this automatically anytime there are commits to the cc @ericnakagawa who has been leading the localization effort until now. |
I think we already have something configured with Yarn to automate it - Crowdin is automatically updated when changes are committed to the English versions. I'm not quite sure how it works though. |
Thanks Daniel. I added a note to the description of this issue to check what Yarn's doing for this. |
It seems like Crowdin have some sort of Github integration now. I don't think Yarn is using this though: https://support.crowdin.com/github-integration/. James Kyle set up the Yarn one, it might be worth reaching out to him. |
Hi hi hi, yes I use https://github.com/thejameskyle/crowdin-sync for Yarn |
I'm interested in helping out with this as well. 🙂 @KyleAMathews @Daniel15 Do you guys have a preference on whether we do this through Github integration or just in time (during the build)? |
I don't think it really makes sense to commit translations to the repo, since CrowdIn already tracks changes to them. We should just have a single source of truth. Either way is fine though, I don't have a strong opinion about it. |
I think we have a couple of options that may be worth exploring. I have been leaning toward using the Crowdin API to pull data at build-time. If this turns out to be slow (either the API or the resulting Gatsby build time) then we can provide a mode to disable/bypass it for local dev use, or to only pull a subset of languages, etc. |
For what it's worth, on the Yarn site we only pull down localizations in the prod build.
|
Agreed that we shouldn't do them for |
I mentioned it in an earlier comment: #82 (comment)
It's on the page you linked to, under the "GeoIP and Language-based redirects" heading. 😛 Here's what the language redirects look like for the Yarn site, as an example: https://gist.github.com/Daniel15/d84b39e8a260ee2a7d627751d015181b |
I guess I misunderstood the section of the docs on the page I linked to. The comment you linked to is a month old. I guess I forgot it. /shrug Thanks for linking to the Yarn redirects file. The Gatsby redirects plug-in will need an update to support the additional language parameter but that should be pretty straight forward. The |
PR to add support to Gatsby + |
May be worth noting, explicitly, that we don't plan to support localization for pages like the "Blog" landing page. (There's no plans to translate blog post content.) If we did decide to support that in the future, we would need to fork the page it somehow so that its GraphQL query only pulled in localized content. |
Hi there, I have a question about localization. |
That's not currently possible, @techhtml. Once this issue is done, it will be. |
@bvaughn Thank you! i'll wait that work done. |
@ericnakagawa Hi Eric, I have question about crowdin localization. I translate |
Hey @techhtml, I believe your translations need to be reviewed and approved by an admin of the React project on Crowdin before your changes appear. |
@clemmy of course. Other Korean developers will help reviews my translations. |
Hi, I logged in to Crowdin after a while, and found the "translated" percentage of Japanese has dropped to 65%. It was 100% (i.e., translation completed) in September last year, but no one but translators themselves had a chance to read the translated docs :) So can someone set up a timeline and a guideline for this on which we can rely on? You have already gathered dozens of volunteers at Crowdin even though you have not officially called for volunteers. Has the localization project started officially, in the first place? Are you going to call for more collaborators, in the blog for example? When are we expected to finish the translation? I don't think the entire Crowdin project may be abandoned, but since there is no timeline nor document to guide the translators, I don't know when we can restart translating to keep up with the current doc. I don't even know what those "master" and "test-17" folders mean. (BTW, I just found the translation percentage for the "master" folder is now 1%... Does this mean almost all the effort we already made on the "old" master is going to disappear soon?) |
Can we expect some progress before the release of React hooks? For now, articles related to hooks are not even listed in the Crowdin repository, and it appears to me that this effort has been half-abandoned recently. It's sad to see developers in my country have to depend on fairly insufficient personal blog articles when such a big change is approaching to the ecosystem. By the way, does anyone know why materials in Crowdin are in HTML format rather than Markdown? HTML tags, especially all those ping @bvaughn @ericnakagawa |
Sorry, I don't have any updates/estimates for this. The core team is spread very thin and I don't think anyone owns this effort at the moment 😞 |
I see. Meanwhile, is it possible to allow translators to download/export their existing contributions from Crowdin? If I understand correctly, this can be done by changing the project settings. Then each translator may host the translated version elsewhere on the internet, say, my GH pages. |
That's something I think @ericnakagawa would have to manage. I don't know much about our Crowdin setup. Not even sure if I would have the necessary permissions. |
To give an update — if everything works out, we expect a person to jump on finishing the integration in one of the next weeks. Can't promise to get it done before Hooks are stable though but it's on our radar. |
For the record, here are some problems I'm currently seeing as a translator.
|
For Yarn we use Markdown in CrowdIn (at https://i18n.yarnpkg.com/), so this might just be an issue with how it's configured for React. Should be straightforward to fix it 😃 |
<!-- Thank you for the PR! Contributors like you keep React awesome! Please see the Contribution Guide for guidelines: https://github.com/reactjs/reactjs.org/blob/master/CONTRIBUTING.md If your PR references an existing issue, please add the issue number below --> reactjs#1
Add explicit heading IDs
Migrated from facebook/react/issues/8063
Coordinate with docs translators via @ericnakagawa
This issue involves multiple steps:
Integrate with Crowdin
This could be done via a custom Gatsby plug-in. We've already written a couple. (It would be nice to work with @KyleAMathews to share this plug-in back with Gatsby so that other users could benefit from it as well.)
If we run into any performance problems, @ericnakagawa has volunteered to work with Netlify and Crowdin to simplify or speed up this syncing process. Ideally this sync process will be fast enough to allow Netlify's PR previews to also be used to test localized builds of the site.
Misc thoughts and questions
/docs/<file>
,/docs/<lang>/<file>
)?The text was updated successfully, but these errors were encountered: