fix(Transition): Stale nodes in transition callbacks

[eps1lon]

• 3f3c1e3 for the current behavior
• 7003c58 for the fix

The issues is that findDOMNode is only called a single time after componentDidUpdate and the return value is used for every transition callback that is triggered by this update. If the child however changes its DOM node while transitioning this value is stale.

Edit: This is now a breaking change from 4.4.0 because #559 changes the signatures of on* callbacks when nodeRef is used. I think this behavior is unnecessary and makes it harder to reason about the component.

[iamandrewluca]

@silvenon I think this can be closed. See #559

[eps1lon]

@silvenon I think this can be closed. See #559

I'll rebase and see if the bug persists. But I suspect this still happens for Transition using findDOMNode.

[iamandrewluca]

As a note. When user is passing nodeRef prop, node should not be passed to callback functions.

[iamandrewluca]

The issues is that findDOMNode is only called a single time after componentDidUpdate and the return value is used for every transition callback that is triggered by this update. If the child however changes its DOM node while transitioning this value is stale.

I'm looking into code and it seems after #559 statement above is false one?!
Or I don't understand exactly what you mean.

Also current implementation in this PR, it seems just to add back node in callback functions. this.getNode does not add too much value 🤔

[eps1lon]

this.getNode does not add too much value thinking

I could inline it sure. But it's used often enough that I think abstracting it is warranted.