-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/update appraisals #934
Conversation
@ttanimichi Appears to be some failing test unrelated to this appraisal change. Must say in general I'm finding Travis a little flakey at times but this one does seem like a real failure on Webpacker 3. |
This grid in Travis is roughly what I'm aiming for:
|
Reverted as Ruby 2.6.2 can't seem to
|
With this merged now, does that mean webpacker 4.x is actually supported? If so.. should the README get updated to say so? Ref: #983 |
@0xdevalias thanks for asking for clarity on this. Webpacker 4.x is supported in that it didn't crash the tests. I haven't personally tried it yet as my time is limited. |
Summary
Adds Rails 5.2 + Webpacker 3, 4.pre versions to appraisal, with Webpacker 4.pre set as allow fail.
Closes #918