Skip to content

Commit

Permalink
Chore/fix chromedriver again (#1004)
Browse files Browse the repository at this point in the history
* Upgrade all Yarn deps in Test folders

* Migrate to webdrivers gem

* Revert Bundle Renderer test to before #792

Add pry-byebug for ease of debugging.
Update the locally used react_ujs to 2.5.0

* Use travis recommended chrome config
  • Loading branch information
BookOfGreg authored Jul 27, 2019
1 parent 24816cb commit 0b244fe
Show file tree
Hide file tree
Showing 12 changed files with 13,599 additions and 6,505 deletions.
6 changes: 6 additions & 0 deletions .pryrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
if defined?(PryByebug)
Pry.commands.alias_command 's', 'step'
Pry.commands.alias_command 'n', 'next'
Pry.commands.alias_command 'f', 'finish'
Pry.commands.alias_command 'c', 'continue'
end
3 changes: 1 addition & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,4 @@ before_install:
- sudo apt-get update -qq
- sudo apt-get install -y -qq yarn
- gem update --system
- gem install chromedriver-helper
- chromedriver-update
- google-chrome-stable --headless --disable-gpu --remote-debugging-port=9222 http://localhost &
1 change: 1 addition & 0 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ end
task default: :test

task :test_setup do
load 'webdrivers/Rakefile'
Dir.chdir('./test/dummy_sprockets') do
`yarn install`
end
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
"webpack": "^2.3.3"
},
"dependencies": {
"react_ujs": "^2.4.4"
"react_ujs": "^2.5.0"
}
}
3 changes: 2 additions & 1 deletion react-rails.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,12 @@ Gem::Specification.new do |s|
s.add_development_dependency 'guard-minitest'
s.add_development_dependency 'jbuilder'
s.add_development_dependency 'listen', '~> 3.0.0' # support Ruby 2.1
s.add_development_dependency 'chromedriver-helper'
s.add_development_dependency 'webdrivers'
s.add_development_dependency 'capybara'
s.add_development_dependency 'selenium-webdriver'
s.add_development_dependency 'test-unit', '~> 2.5'
s.add_development_dependency 'rails', '>= 3.2'
s.add_development_dependency 'pry-byebug'

s.add_dependency 'connection_pool'
s.add_dependency 'execjs'
Expand Down
Loading

0 comments on commit 0b244fe

Please sign in to comment.