Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rename-unsafe-lifecycles codemod #195

Merged
merged 2 commits into from
Jan 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,14 @@ jscodeshift -t react-codemod/transforms/React-PropTypes-to-prop-types.js <path>

* In addition to running the above codemod you will also need to install the 'prop-types' NPM package.

#### `rename-unsafe-lifecycles`

Adds "UNSAFE_" prefix for deprecated lifecycle hooks. (For more information about this codemod, see [React RFC #6](https://github.com/reactjs/rfcs/pull/6))

```sh
jscodeshift -t react-codemod/transforms/rename-unsafe-lifecycles.js <path>
```

#### `react-to-react-dom`

Updates code for the split of the `react` and `react-dom` packages (e.g.,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
const React = require('React');

class Component extends React.Component {
componentWillMount = logger('componentWillMount');
componentDidMount = logger('componentDidMount');
componentWillReceiveProps = logger('componentWillReceiveProps');
shouldComponentUpdate = logger('shouldComponentUpdate');
componentWillUpdate = logger('componentWillUpdate');
componentDidUpdate = logger('componentDidUpdate');
componentWillUnmount = logger('componentWillUnmount');
render() {
return null;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
const React = require('React');

class Component extends React.Component {
UNSAFE_componentWillMount = logger('componentWillMount');
componentDidMount = logger('componentDidMount');
UNSAFE_componentWillReceiveProps = logger('componentWillReceiveProps');
shouldComponentUpdate = logger('shouldComponentUpdate');
UNSAFE_componentWillUpdate = logger('componentWillUpdate');
componentDidUpdate = logger('componentDidUpdate');
componentWillUnmount = logger('componentWillUnmount');
render() {
return null;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
const createReactClass = require('create-react-class');

const MyComponent = createReactClass({
displayName: 'MyComponent',
mixins: [
{
componentWillMount() {
// componentWillMount
},
componentDidMount() {
// componentDidMount
},
componentWillUpdate(nextProps, nextState) {
// componentWillUpdate
},
componentDidUpdate(prevProps, prevState) {
// componentDidUpdate
},
componentWillReceiveProps(nextProps) {
// componentWillReceiveProps
},
componentWillUnmount() {
// componentWillUnmount
},
},
],
componentWillMount() {
// componentWillMount
},
componentDidMount() {
// componentDidMount
},
componentWillUpdate(nextProps, nextState) {
// componentWillUpdate
},
componentDidUpdate(prevProps, prevState) {
// componentDidUpdate
},
componentWillReceiveProps(nextProps) {
// componentWillReceiveProps
},
componentWillUnmount() {
// componentWillUnmount
},
render() {
// render
},
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
const createReactClass = require('create-react-class');

const MyComponent = createReactClass({
displayName: 'MyComponent',
mixins: [
{
UNSAFE_componentWillMount() {
// componentWillMount
},
componentDidMount() {
// componentDidMount
},
UNSAFE_componentWillUpdate(nextProps, nextState) {
// componentWillUpdate
},
componentDidUpdate(prevProps, prevState) {
// componentDidUpdate
},
UNSAFE_componentWillReceiveProps(nextProps) {
// componentWillReceiveProps
},
componentWillUnmount() {
// componentWillUnmount
},
},
],
UNSAFE_componentWillMount() {
// componentWillMount
},
componentDidMount() {
// componentDidMount
},
UNSAFE_componentWillUpdate(nextProps, nextState) {
// componentWillUpdate
},
componentDidUpdate(prevProps, prevState) {
// componentDidUpdate
},
UNSAFE_componentWillReceiveProps(nextProps) {
// componentWillReceiveProps
},
componentWillUnmount() {
// componentWillUnmount
},
render() {
// render
},
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
const React = require('React');

class ClassComponent extends React.Component {
componentWillMount() {
// componentWillMount
}
componentDidMount() {
// componentDidMount
}
componentWillUpdate(nextProps, nextState) {
// componentWillUpdate
}
componentDidUpdate(prevProps, prevState) {
// componentDidUpdate
}
componentWillReceiveProps(nextProps) {
// componentWillReceiveProps
}
componentWillUnmount() {
// componentWillUnmount
}
render() {
// render
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
const React = require('React');

class ClassComponent extends React.Component {
UNSAFE_componentWillMount() {
// componentWillMount
}
componentDidMount() {
// componentDidMount
}
UNSAFE_componentWillUpdate(nextProps, nextState) {
// componentWillUpdate
}
componentDidUpdate(prevProps, prevState) {
// componentDidUpdate
}
UNSAFE_componentWillReceiveProps(nextProps) {
// componentWillReceiveProps
}
componentWillUnmount() {
// componentWillUnmount
}
render() {
// render
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
function componentWillMount() {
// componentWillMount
}
function componentWillUpdate(nextProps, nextState) {
// componentWillUpdate
}
function componentWillReceiveProps(nextProps) {
// componentWillReceiveProps
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class SomeClass {
someMethod() {
const componentWillMount = true;
let componentWillUpdate = 123;
var componentWillReceiveProps = 'abc';
}
}
32 changes: 32 additions & 0 deletions transforms/__tests__/rename-unsafe-lifecycles-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
/**
* Copyright 2013-2015, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
*/

'use strict';

const tests = [
'arrow-functions',
'create-react-class',
'instance-methods',
'standalone-function',
'variable-within-class-method',
];

const defineTest = require('jscodeshift/dist/testUtils').defineTest;

describe('rename-unsafe-lifecycles', () => {
tests.forEach(test =>
defineTest(
__dirname,
'rename-unsafe-lifecycles',
null,
`rename-unsafe-lifecycles/${test}`
)
);
});
57 changes: 57 additions & 0 deletions transforms/rename-unsafe-lifecycles.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
/**
* Copyright 2013-2015, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
*/

'use strict';

const DEPRECATED_APIS = Object.create(null);
DEPRECATED_APIS.componentWillMount = 'UNSAFE_componentWillMount';
DEPRECATED_APIS.componentWillReceiveProps = 'UNSAFE_componentWillReceiveProps';
DEPRECATED_APIS.componentWillUpdate = 'UNSAFE_componentWillUpdate';

export default (file, api, options) => {
const j = api.jscodeshift;

const printOptions = options.printOptions || {
quote: 'single',
trailingComma: true,
};

const root = j(file.source);

let hasModifications = false;

const renameDeprecatedApis = path => {
const name = path.node.key.name;

if (DEPRECATED_APIS[name]) {
path.value.key.name = DEPRECATED_APIS[name];
hasModifications = true;
}
};

// Class methods
root
.find(j.MethodDefinition)
.forEach(renameDeprecatedApis);

// Arrow functions
root
.find(j.ClassProperty)
.forEach(renameDeprecatedApis);

// createReactClass and mixins
root
.find(j.Property)
.forEach(renameDeprecatedApis);

return hasModifications
? root.toSource(printOptions)
: null;
};