Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Optional Content: Warnings #767

Merged
merged 7 commits into from
Nov 4, 2024
Merged

Translate Optional Content: Warnings #767

merged 7 commits into from
Nov 4, 2024

Conversation

pecraveiro
Copy link
Contributor

Olá! Estou enviando um PR de toda a tradução de conteúdo opcional: Warnings.

@vercel Vercel
Copy link

vercel bot commented Jun 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
pt-br-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Jun 29, 2024 3:23pm

@pecraveiro pecraveiro mentioned this pull request Jun 26, 2024
Open
@pecraveiro pecraveiro changed the title Tradução de Conteúdo opcional: Warnings Translate Optional Content: Warnings Jun 26, 2024
rick-ssa
rick-ssa suggested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@rick-ssa rick-ssa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parabéns!!! Um belo trabalho foi feito aqui!
Fiz algumas poucas sugestões de alterações.

src/content/warnings/invalid-aria-prop.md Outdated Show resolved Hide resolved
src/content/warnings/invalid-aria-prop.md Outdated Show resolved Hide resolved
src/content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
src/content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
src/content/warnings/invalid-hook-call-warning.md Outdated Show resolved Hide resolved
pecraveiro and others added 5 commits June 27, 2024 01:29
@pecraveiro @rick-ssa
Update src/content/warnings/invalid-aria-prop.md
4a3e06a 
Alterações solicitadas pelo @rick-ssa via PR.

Co-authored-by: Ricardo Santos da Silva <34078950+rick-ssa@users.noreply.github.com>
@pecraveiro @rick-ssa
Update src/content/warnings/invalid-aria-prop.md
8e37c4e 
Alterações solicitadas pelo @rick-ssa via PR.

Co-authored-by: Ricardo Santos da Silva <34078950+rick-ssa@users.noreply.github.com>
@pecraveiro @rick-ssa
Update src/content/warnings/invalid-hook-call-warning.md
129f7c3 
Alterações solicitadas pelo @rick-ssa via PR.

Co-authored-by: Ricardo Santos da Silva <34078950+rick-ssa@users.noreply.github.com>
@pecraveiro @rick-ssa
Update src/content/warnings/invalid-hook-call-warning.md
8b6b887 
Alterações solicitadas pelo @rick-ssa via PR.

Co-authored-by: Ricardo Santos da Silva <34078950+rick-ssa@users.noreply.github.com>
@pecraveiro @rick-ssa
Update src/content/warnings/invalid-hook-call-warning.md
ee98a13 
Alterações solicitadas pelo @rick-ssa via PR.

Co-authored-by: Ricardo Santos da Silva <34078950+rick-ssa@users.noreply.github.com>
rick-ssa
rick-ssa approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@rick-ssa rick-ssa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review aprovada!

@pecraveiro
Copy link
Contributor Author

Obrigado @rick-ssa, da nossa parte falta alguma coisa ou só precisamos aguardar mais uma pessoa revisar o PR?

@rick-ssa
Copy link
Contributor

Obrigado @rick-ssa, da nossa parte falta alguma coisa ou só precisamos aguardar mais uma pessoa revisar o PR?

Acredito que temos que aguardar agora

Zapotoczn
Zapotoczn suggested changes Jun 29, 2024
View reviewed changes
Copy link

@Zapotoczn Zapotoczn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marquei umas sugestões para alteração de umas certas palavras para um bom entendimento, no caso da palavra "props" e a "deprecation", acredito que será de bom agregamento estes comentarios.

Sou junior e novo por aqui, caso sejam comentarios inuteis ou algo sem valia por favor me informe pois estou aprendendo junto com vocês.

src/content/warnings/react-dom-test-utils.md Show resolved Hide resolved
src/content/warnings/react-test-renderer.md Outdated Show resolved Hide resolved
src/content/warnings/unknown-prop.md Show resolved Hide resolved
@Zapotoczn
Copy link

Aprovado!

@pecraveiro
Copy link
Contributor Author

@eduardomoroni Up

jgb27
jgb27 approved these changes Aug 9, 2024
View reviewed changes
Copy link

@jgb27 jgb27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parabéns. Continue assim. Já, já vamos terminar toda documentação.

vinicius77
vinicius77 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@vinicius77 vinicius77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! 🎉

@pecraveiro
Copy link
Contributor Author

@eduardomoroni Up

@pecraveiro pecraveiro closed this Sep 26, 2024
@pecraveiro pecraveiro reopened this Sep 26, 2024
jhonmike
jhonmike approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation was great, I just commented one link from the Mozilla documentation because it is very good in Portuguese too and this will help the Brazilian reader.

src/content/warnings/unknown-prop.md Show resolved Hide resolved
@jhonmike jhonmike added 🌐 translated Translation is completed for this page needs author response Changes requested needing author's input labels Nov 1, 2024
@pecraveiro pecraveiro closed this Nov 1, 2024
@jhonmike jhonmike reopened this Nov 4, 2024
@jhonmike
Copy link
Member

jhonmike commented Nov 4, 2024

Não entendi o motivo de fechar o PR @pecraveiro, vou enviar o código porque ele esta correto e arrumo o link em um PR futuro!!

@jhonmike jhonmike merged commit 7d784ef into reactjs:main Nov 4, 2024
2 of 4 checks passed
@jhonmike jhonmike removed the needs author response Changes requested needing author's input label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zapotoczn Zapotoczn Zapotoczn approved these changes

@jgb27 jgb27 jgb27 approved these changes

@rick-ssa rick-ssa rick-ssa approved these changes

@jhonmike jhonmike jhonmike approved these changes

@vinicius77 vinicius77 vinicius77 approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pecraveiro @rick-ssa @Zapotoczn @jhonmike @vinicius77 @jgb27