Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate typechecking-with-proptypes.md #67

Merged

Conversation

Naturalclar
Copy link
Contributor

This PR is part of #4
Translated typechecking-with-proptypes.md into Japanese.

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらの確認をお願いします。

content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
@Naturalclar
Copy link
Contributor Author

レビューありがとうございます、指摘された箇所を修正しました:bow:

@Naturalclar Naturalclar changed the title doc: translate typechecking with proptypes Translate typechecking-with-proptypes.md Feb 6, 2019
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naturalclar
翻訳お疲れ様です!一点、コメントしたので見ていただけると幸いです。

imo なので必須!というわけではなく、意見を聞きたい部分です。

content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
@tesseralis tesseralis mentioned this pull request Feb 9, 2019
90 tasks
@Naturalclar
Copy link
Contributor Author

ルール改正されたTextLintを走らせました:bow:

@smikitky
Copy link
Member

@potato4d もう2名のレビューは済んでおり approve だけだと思うので確認をお願いします

@potato4d
Copy link
Member

@smikitky 🙇

@potato4d potato4d merged commit 558bc13 into reactjs:master Feb 13, 2019
@smikitky
Copy link
Member

@potato4d @Naturalclar ありがとうございました!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants