Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate add-react-to-a-website #19

Merged
merged 6 commits into from
Feb 4, 2019

Conversation

sato11
Copy link
Contributor

@sato11 sato11 commented Feb 1, 2019

This PR is part of #4.
Added translation to Add React to a Website section.

The hardest part for me was the word Tip. The first wording that came up in me was コツ but it sounded a little inappropriate because this document is supposed to work right without tips, and nothing like コツ should be required.
Will you give me an agreed wording if there is any, or whatever suggestion that you think is the best?

For other parts I tried to be fair, but will appreciate if you point me any weird wordings or ambiguities.
Thanks!

@smikitky smikitky self-requested a review February 1, 2019 23:47
@smikitky
Copy link
Member

smikitky commented Feb 1, 2019

ひとまず

  • Note = 補足
  • Tip = ヒント

になる予定です

@tesseralis tesseralis mentioned this pull request Feb 1, 2019
90 tasks
@sato11
Copy link
Contributor Author

sato11 commented Feb 2, 2019

@smikitky
ありがとうございます!
今回 Optional に「補足」と当ててしまっているのですがこちらにも何か決まった言い回しはありますか?

@smikitky
Copy link
Member

smikitky commented Feb 2, 2019

そこに決まりはありませんが、「この作業はやってもやらなくてもいい」という意味なので普通に「オプション」でいい気がします。

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、中身の話に入る前に形式的なところからですが、

  • 句読点と英字の間にスペースを入れない (例:を作成し、␣HTML ファイル)
  • 句点と次の文との間にスペースを入れない (例:ません。␣まずは
  • # によるページ内アンカーへのリンク名は改変しない ( Support explicit heading IDs react.dev#1608 にてまとめて対応されます)

について一通り修正していただいていいでしょうか。
textlint がもっと賢くなればチェックできるようになると思いますが

@sato11
Copy link
Contributor Author

sato11 commented Feb 3, 2019

@smikitky
コメントありがとうございました。
いただいた部分について修正しましたので改めてご確認お願いできますでしょうか。

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

数が多いですが大部分は記号やスペースの問題です。
また、必須ではないところで原文から少し離れすぎていると感じられる部分について少し手直しの提案をさせていただきました。他の翻訳と調子を合わせる必要もありますのでご理解いただければ幸いです。

content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
@sato11
Copy link
Contributor Author

sato11 commented Feb 3, 2019

@smikitky
確認させていただきました。

他の翻訳と調子を合わせる必要もありますので

こちらに異存はありません。
ご丁寧にみてくださってありがとうございます!

@sato11 sato11 force-pushed the translate/add-react-to-a-website branch from 2518464 to 3c7cb21 Compare February 3, 2019 13:10
@sato11
Copy link
Contributor Author

sato11 commented Feb 3, 2019

@smikitky
指摘いただいた部分を愚直に直したという感じです。
引き続きよろしくお願いします。

@smikitky smikitky merged commit 3c7cb21 into reactjs:master Feb 4, 2019
@smikitky
Copy link
Member

smikitky commented Feb 4, 2019

ありがとうございました!

@sato11 sato11 deleted the translate/add-react-to-a-website branch February 4, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants