Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated editor-setup page to hindi #246

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

Subramanyarao11
Copy link
Contributor

No description provided.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

I have added review for few lines, once these are fixes this will be go to be merged.

src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@arshadkazmi42 arshadkazmi42 merged commit a6af534 into reactjs:main Oct 2, 2023
2 checks passed
@Subramanyarao11
Copy link
Contributor Author

Looks good. Thanks
Thank you so much for your thorough review and valuable suggestions! Your guidance was instrumental in getting this code merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st Review First phase of review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants