Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exhaust.ts): renamed exhaust to exhaustAll #5639

Merged
merged 7 commits into from
Feb 12, 2021

Conversation

BioPhoton
Copy link
Contributor

@BioPhoton BioPhoton commented Aug 9, 2020

Description:

As proposed in #4573 I renamed exhaust to exhaustAll and exposed the old as an alias that I deprecated.

Notice:
This PR changes the public API and therefore I had to run npm run api_guardian:update.
I added the generated changes in a separate commit.

Things changed:

  • renamed exhaust to exhaustAll
  • exported exhaustAll with alias exhaust
  • tested export of exhaustAll and exhaust
  • deprecated exhaust
  • updated tests to use new method name
  • updated api_guard/dist/types/operators/index.d.ts by running npm run api_guardian:update

Related issue (if exists):
closes #4573

@BioPhoton BioPhoton force-pushed the 4573_rename-exhaust-to-exhaustall branch from 84d9280 to d570663 Compare August 20, 2020 11:20
@BioPhoton
Copy link
Contributor Author

Hi, @jakovljevic-mladen my IDE did an auto rename and I was too lazy to check it. :D
So here we go, I fixed all the broken tests, exports, namings.

@jakovljevic-mladen
Copy link
Member

Cool, thanks @BioPhoton. I'm sorry, but there's another file left that could be renamed: spec/operators/exhaust-spec.ts -> spec/operators/exhaustAll-spec.ts.

Copy link
Member

@benlesh benlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good... Can we rename the usage in the dtslint files as well?

@benlesh
Copy link
Member

benlesh commented Sep 21, 2020

Unfortunately, this all may need redone after #5729 lands. Marking as blocked for now.

@BioPhoton
Copy link
Contributor Author

Ok. No problem at all. I'll skip the last reaming and redo everything when you give me the GO.

👍

@benlesh
Copy link
Member

benlesh commented Oct 2, 2020

Okay, @BioPhoton, give it a go now. You can probably reuse parts of this PR, so I'll leave it open.

Thank you for your hard work. (Ping me on Twitter if I don't notice when you update this)

@cartant cartant force-pushed the 4573_rename-exhaust-to-exhaustall branch from 93c32d9 to 3f6e56e Compare November 7, 2020 05:04
@cartant
Copy link
Collaborator

cartant commented Nov 7, 2020

@benlesh I've rebased this. It should to okay to merge once it passes CI.

@cartant cartant removed the blocked label Nov 7, 2020
@benlesh benlesh self-assigned this Jan 27, 2021
@benlesh benlesh force-pushed the 4573_rename-exhaust-to-exhaustall branch from 3f6e56e to 072483e Compare February 12, 2021 20:54
@benlesh benlesh merged commit 701c7d4 into ReactiveX:master Feb 12, 2021
@benlesh
Copy link
Member

benlesh commented Feb 12, 2021

lol... finally got this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs]: Rename/Alias the exhaust operator to exhaustAll
4 participants