-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exhaust.ts): renamed exhaust to exhaustAll #5639
feat(exhaust.ts): renamed exhaust to exhaustAll #5639
Conversation
84d9280
to
d570663
Compare
Hi, @jakovljevic-mladen my IDE did an auto rename and I was too lazy to check it. :D |
Cool, thanks @BioPhoton. I'm sorry, but there's another file left that could be renamed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good... Can we rename the usage in the dtslint files as well?
Unfortunately, this all may need redone after #5729 lands. Marking as blocked for now. |
Ok. No problem at all. I'll skip the last reaming and redo everything when you give me the GO. 👍 |
Okay, @BioPhoton, give it a go now. You can probably reuse parts of this PR, so I'll leave it open. Thank you for your hard work. (Ping me on Twitter if I don't notice when you update this) |
93c32d9
to
3f6e56e
Compare
@benlesh I've rebased this. It should to okay to merge once it passes CI. |
3f6e56e
to
072483e
Compare
lol... finally got this in. |
Description:
As proposed in #4573 I renamed
exhaust
toexhaustAll
and exposed the old as an alias that I deprecated.Notice:
This PR changes the public API and therefore I had to run
npm run api_guardian:update
.I added the generated changes in a separate commit.
Things changed:
exhaust
toexhaustAll
exhaustAll
with aliasexhaust
exhaustAll
andexhaust
exhaust
api_guard/dist/types/operators/index.d.ts
by runningnpm run api_guardian:update
Related issue (if exists):
closes #4573