Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading WPF BitmapImage from a network stream #793

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Fix loading WPF BitmapImage from a network stream #793

merged 4 commits into from
Oct 21, 2021

Conversation

n-ski
Copy link
Contributor

@n-ski n-ski commented Oct 16, 2021

What kind of change does this PR introduce?
Fixes an issue where BitmapLoader.Current.Load() will throw an InvalidOperationException if a network stream is supplied on Windows platforms.

What is the current behavior?
See #792.

What is the new behavior?
Bitmap is loaded correctly, but the underlying BitmapImage isn't frozen.

What might this PR break?
Shouldn't break anything.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
Let me know if I missed anything.

@dnfadmin
Copy link

dnfadmin commented Oct 16, 2021

CLA assistant check
All CLA requirements met.

@glennawatson glennawatson enabled auto-merge (squash) October 16, 2021 22:58
auto-merge was automatically disabled October 21, 2021 22:39

Head branch was pushed to by a user without write access

@dpvreony dpvreony enabled auto-merge (squash) October 21, 2021 22:46
@glennawatson glennawatson changed the title #792 Fix loading WPF BitmapImage from a network stream Fix loading WPF BitmapImage from a network stream Oct 21, 2021
@glennawatson glennawatson disabled auto-merge October 21, 2021 22:55
@glennawatson glennawatson enabled auto-merge (squash) October 21, 2021 22:55
@glennawatson glennawatson merged commit 24009a9 into reactiveui:main Oct 21, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants