Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Enable deterministic builds #783

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Conversation

glennawatson
Copy link
Contributor

What kind of change does this PR introduce?

housekeeping

What is the current behavior?

Builds aren't considered deterministic, so it's harder for third parties to verify the source of the package.

What is the new behavior?

The following settings are turned on

  • EmbedUntrackedSources should be enabled so that compiler-generated source, like AssemblyInfo, are included in the PDB.
  • ContinuousIntegrationBuild when GitHub actions are running to indicate to outside users the build was done via a CI server.
  • IncludePackageReferencesDuringMarkupCompilation which will allow the Markup Compilation to know about the package references

What might this PR break?
Shouldn't break anyone.

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #783 (6e45f06) into main (b88147a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #783   +/-   ##
=======================================
  Coverage   74.49%   74.49%           
=======================================
  Files          99       99           
  Lines        4968     4968           
=======================================
  Hits         3701     3701           
  Misses       1267     1267           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b88147a...6e45f06. Read the comment docs.

@glennawatson glennawatson enabled auto-merge (squash) October 1, 2021 02:20
@glennawatson glennawatson merged commit beccc78 into main Oct 1, 2021
@glennawatson glennawatson deleted the glennawatson-patch-1 branch October 1, 2021 03:04
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants