housekeeping: move to using Verify #781
Conversation
|
will fix the build today |
|
No problem, thanks |
|
@glennawatson btw is the regex cleanup redundant? i tried removing it and the tests still pass? or is the |
| using Xunit; | ||
|
|
||
| #pragma warning disable SA1615 // Element return value should be documented |
There was a problem hiding this comment.
I would prefer this to be suppressed in test projects. let me know if you want a PR
|
also this should be squashed on merge |
It's potentially redundant since it was used in the coverage tool prior to coverlet. |
|
I'll be holding off merging this PR probably to the end of the day. Gotta work out why the coverage reports aren't uploading in general. |
|
no worries on holding off. let me know if u want the regex removed as part of this pr |
|
Go ahead and remove that regex. I think the codecov thing is likely just due to you being on a fork since it worked for another PR of mine. |
|
regex removed |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
So i was wading through the code, and noticed you use DiffEngine and also have a custom implementation of snapshot testing. So i figured i would throw up a PR that removes ApiExtensions.cs