fix for DryIoc - Change Append to Replace for keyed (contract) registrations #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for #752 Keyed instances can only have a single instance so keep latest
Codecov Report
@@ Coverage Diff @@
## main #753 +/- ##
==========================================
+ Coverage 74.43% 74.70% +0.27%
==========================================
Files 99 99
Lines 4968 4970 +2
==========================================
+ Hits 3698 3713 +15
+ Misses 1270 1257 -13
Continue to review full report at Codecov.
|
dpvreony
approved these changes
Aug 18, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #752 Keyed instances can only have a single instance so keep latest
What kind of change does this PR introduce?
DryIoc only allows single registrations for keyed (Contract) registrations
What is the current behaviour?
DryIoc currently crashes when a duplicate registration is made with contract
What is the new behaviour?
DryIoc now replaces the registration with the new instance
What might this PR break?
none expected as would previously throw an exception in this instance
Please check if the PR fulfils these requirements
Other information:
This issue stemmed from Akavache due to a double call to Registrations Akavache.Core.Registrations which registers a default InMemory Cache and Akavache.Sqlite3.Registrations with a db Cache, both are called with the same registration details.