feature resolvers changed to allow registration of null with a value type #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presently Getservice casts to a nullable return value object? or T?, now returns the value as a object or T
Codecov Report
@@ Coverage Diff @@
## main #721 +/- ##
==========================================
+ Coverage 73.31% 74.20% +0.89%
==========================================
Files 98 99 +1
Lines 4835 4967 +132
==========================================
+ Hits 3545 3686 +141
+ Misses 1290 1281 -9
Continue to review full report at Codecov.
|
|
As discussed offline GetService probably should return nullable to indicate non registration or deliberate null. |
… null if not valid housekeeping on tests fix ILogManager_Resolvable test
glennawatson
reviewed
Jul 1, 2021
glennawatson
reviewed
Jul 1, 2021
glennawatson
reviewed
Jul 1, 2021
matched the GetServices to also return IEmeumerable<object?>
ChrisPulman
changed the title
dpvreony
reviewed
Jul 5, 2021
dpvreony
reviewed
Jul 7, 2021
|
i've done a branch f50a072 to think through the getservices bit. will look again over weekend |
|
re-opening so i can track what i am looking at on getservices against this branch rather than diff master |
* WIP: tweaks for getservices * warnings as errors for nullable * attempt to tidy up getservices warnings * remove bak files * change autofac to use Enumerable.Empty
found an issue with Dryloc resolver with contracts, returns the wrong instance
ChrisPulman
changed the title
items registered with Dryloc resolver were not retained but overwritten where multiple registrations were made with the same serviceType and different contracts
need to refresh codecov to discover remaining tests required
…b.com/reactiveui/splat into fix_GetServiceShouldntReturnANullable
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix for dryloc resolver
feature for some resolvers to use a null serviceType and a Func of value type to be registered
What is the current behaviour?
Presently only one resolver can resolve null service types
Dryloc resolver fails to resolve multiple services with the same type and differing contracts
What is the new behaviour?
increased the number of resolvers that can resolve Func of value type.
Dryloc resolver now resolves multiple services with the same type and differing contracts
What might this PR break?
people using dryloc may experience a different item being resolved now compared to previously, but will now return the correct service
Please check if the PR fulfils these requirements
Other information:
Test projects have the Func of value type and null serviceType applied
FuncDependencyResolver and SimpleInjectorDependencyResolver do not currently support Func of value type