Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpleinjector reimplementation #631

Merged
merged 6 commits into from
Dec 2, 2020
Merged

Simpleinjector reimplementation #631

merged 6 commits into from
Dec 2, 2020

Conversation

jposert
Copy link
Contributor

@jposert jposert commented Nov 15, 2020

What kind of change does this PR introduce?
Bugfix

What is the current behavior?
Currently there's no way to use SimpleInjector in projects.

What is the new behavior?
SimpleInjector works well with Splat & ReactiveUI initializations.

What might this PR break?
Probably nothing.

Please check if the PR fulfills these requirements

  • [ x] Tests for the changes have been added (for bug fixes / features)
  • [ x] Docs have been added / updated (for bug fixes / features)

Other information:
I've tested the solution with my very small project based on WPF - all works okay. Anyway, I've no clue about performance of the solution (probably most important thing on mobile platforms).

@dnfadmin
Copy link

dnfadmin commented Nov 15, 2020

CLA assistant check
All CLA requirements met.

@glennawatson
Copy link
Contributor

There's some failing unit tests unfortunately. You can click the build action to see the details.

Thanks for the work so far

@jposert
Copy link
Contributor Author

jposert commented Nov 16, 2020

I made a little mistake and i pushed invalid code (sorry). For now, everything should be okay but the build is failing - and I'm not sure why or how to fix it. It's all building on my machine and it passes all the tests successfully.

@glennawatson
Copy link
Contributor

The latest is a build error that is on and off we've seen before with Nerdbank git versioning tool we use. I might make a report to the library author.

Copy link
Member

@dpvreony dpvreony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, few threading tweaks and some bits around the read me just to expand\ clarify knowledge

src/Splat.SimpleInjector/SimpleInjectorInitializer.cs Outdated Show resolved Hide resolved
src/Splat.SimpleInjector/SimpleInjectorInitializer.cs Outdated Show resolved Hide resolved
src/Splat.SimpleInjector/SimpleInjectorInitializer.cs Outdated Show resolved Hide resolved
src/Splat.SimpleInjector/SimpleInjectorInitializer.cs Outdated Show resolved Hide resolved
src/Splat.SimpleInjector/SimpleInjectorInitializer.cs Outdated Show resolved Hide resolved
src/Splat.SimpleInjector/README.md Show resolved Hide resolved
src/Splat.SimpleInjector/README.md Show resolved Hide resolved
@dpvreony
Copy link
Member

dpvreony commented Nov 20, 2020

closes #597

@dpvreony dpvreony linked an issue Nov 20, 2020 that may be closed by this pull request
@dpvreony
Copy link
Member

dpvreony commented Dec 2, 2020

cleaned up. documented weakness in dupe registrations

@dpvreony dpvreony merged commit a283837 into reactiveui:main Dec 2, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Splat.SimpleInjector - not possible to do a setup.
4 participants