Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add .NET 5 support #627

Merged
merged 10 commits into from
Nov 11, 2020
Merged

feature: Add .NET 5 support #627

merged 10 commits into from
Nov 11, 2020

Conversation

glennawatson
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #627 (b5dbd49) into main (e62f8c0) will decrease coverage by 23.57%.
The diff coverage is 47.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #627       +/-   ##
===========================================
- Coverage   70.47%   46.90%   -23.58%     
===========================================
  Files          75      127       +52     
  Lines        4003     6823     +2820     
===========================================
+ Hits         2821     3200      +379     
- Misses       1182     3623     +2441     
Impacted Files Coverage Δ
...lat.Drawing/Platforms/net5/Bitmaps/BitmapMixins.cs 0.00% <0.00%> (ø)
...t.Drawing/Platforms/net5/Colors/ColorExtensions.cs 0.00% <0.00%> (ø)
...wing/Platforms/net5/Colors/SplatColorExtensions.cs 0.00% <0.00%> (ø)
...at.Drawing/Platforms/net5/Maths/PointExtensions.cs 0.00% <0.00%> (ø)
...lat.Drawing/Platforms/net5/Maths/RectExtensions.cs 0.00% <0.00%> (ø)
...lat.Drawing/Platforms/net5/Maths/SizeExtensions.cs 0.00% <0.00%> (ø)
.../Splat.Raygun/RaygunFeatureUsageTrackingSession.cs 91.11% <ø> (ø)
src/Splat/ServiceLocation/InternalLocator.cs 83.33% <ø> (ø)
...awing/Platforms/net5/Bitmaps/BitmapSourceBitmap.cs 17.64% <17.64%> (ø)
...ing/Platforms/net5/Bitmaps/PlatformBitmapLoader.cs 52.08% <52.08%> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e62f8c0...b5dbd49. Read the comment docs.

@glennawatson
Copy link
Contributor Author

The lower code coverage is correct, since its taking into account a lot more projects now.

Copy link
Member

@RLittlesII RLittlesII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of the sdks might need to be changed.

src/Splat.DryIoc.Tests/Splat.DryIoc.Tests.csproj Outdated Show resolved Hide resolved
glennawatson and others added 2 commits November 12, 2020 05:08
Co-authored-by: Rodney Littles II <6969701+RLittlesII@users.noreply.github.com>
Co-authored-by: Rodney Littles II <6969701+RLittlesII@users.noreply.github.com>
@glennawatson glennawatson merged commit f6158a1 into main Nov 11, 2020
@glennawatson glennawatson deleted the glennawatson-update-net5 branch November 11, 2020 18:52
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants