Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an exception when loading bitmap on Android from file #576

Merged

Conversation

alexshikov
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix.

What is the current behavior?

BitmapLoader.Current.Load() throws exception (NotSupportedException) Stream does not support writing when load the bitmap from the FileStream.

What is the new behavior?

No exception.

What might this PR break?

Nothing. It's flawless.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@alexshikov alexshikov requested a review from a team September 3, 2020 16:59
@glennawatson glennawatson merged commit a0de81e into reactiveui:main Sep 3, 2020
@glennawatson
Copy link
Contributor

Thanks, I pushed a new version with this fix just now.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants