-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using TryResolve instead of Resolve with Autofac #413
Conversation
I think @RLittlesII wanted to give some feedback on this PR so hold on before merging. |
gah that poped up right as I did it :( |
Ah well, I'm sure @RLittlesII can put the feedback and provide another PR if necessary. |
I was honestly wondering if the performance issue was because the exception is thrown. The documentation states that
https://autofaccn.readthedocs.io/en/latest/resolve/ |
I keep on re-reading it and I feel like the part of the documentation contradicts what was stated and demonstrated in the section right above it...
|
Nope, I think I understand what the documentation is saying.. |
What kind of change does this PR introduce?
Fixing
AutofacDependencyResolver
so it does not throw, catch and swallow exceptions while resolving services.What is the current behavior?
I'm currently using
AutofacDependencyResolver
withViewModelViewHost
in aListView
and noticed the massive lag while debugging and the bloat ofComponentNotRegisteredException
s being thrown even though my code works.What is the new behavior?
The new behavior should be the same, except faster when using Autofac and debugging.
What might this PR break?
Nothing I can think of.
Please check if the PR fulfills these requirements
Other information: