Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Move UI functionality to Splat.Drawing #403

Merged
merged 5 commits into from
Sep 20, 2019

Conversation

glennawatson
Copy link
Contributor

@glennawatson glennawatson commented Sep 19, 2019

If users of Blazor/Uno and other .netcoreapp3.0 platforms attempt to compile on a non-windows platform at the moment there will be compile errors. This is due to UseWPF/UseWinForms being enabled on those platforms.

Separating the UI into a different class to allow those applications not to be affected.

Android is now minimum of 9.0

Fix bug in MS DI HasRegistrations

@glennawatson glennawatson requested a review from a team September 19, 2019 10:51
Fix warnings

Fix MS DI bug in HasRegister

Update to android 9.0
@glennawatson glennawatson changed the title housekeeping: Move UI functionality to Splat.UI housekeeping: Move UI functionality to Splat.Drawing Sep 20, 2019
@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #403 into master will decrease coverage by 9.85%.
The diff coverage is 0.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   71.51%   61.66%   -9.86%     
==========================================
  Files          66       70       +4     
  Lines        3697     4367     +670     
  Branches      338      420      +82     
==========================================
+ Hits         2644     2693      +49     
- Misses       1008     1596     +588     
- Partials       45       78      +33
Impacted Files Coverage Δ
src/Splat.Drawing/Bitmaps/BitmapLoader.cs 0% <ø> (ø)
...lat.Drawing/Platforms/net4/Maths/RectExtensions.cs 0% <ø> (ø)
...lat.Drawing/Platforms/net4/Maths/SizeExtensions.cs 0% <ø> (ø)
...t.Drawing/Platforms/net4/Colors/ColorExtensions.cs 0% <ø> (ø)
...ing/Platforms/net4/Bitmaps/PlatformBitmapLoader.cs 0% <ø> (ø)
src/Splat.Drawing/Colors/KnownColors.cs 94.93% <ø> (ø)
...awing/Platforms/net4/Bitmaps/BitmapSourceBitmap.cs 0% <ø> (ø)
src/Splat.Drawing/Bitmaps/BitmapLoaderException.cs 0% <ø> (ø)
...rc/Splat/ServiceLocation/FuncDependencyResolver.cs 30.9% <ø> (ø) ⬆️
...wing/Platforms/net4/Colors/SplatColorExtensions.cs 0% <ø> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b59dff...da8561f. Read the comment docs.

@glennawatson glennawatson merged commit a5315ce into master Sep 20, 2019
@glennawatson glennawatson deleted the glennawatson-ui branch September 20, 2019 11:54
@lock lock bot locked and limited conversation to collaborators Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant