Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping : Update Target Frameworks #1065

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Housekeeping : Update Target Frameworks #1065

merged 1 commit into from
Nov 17, 2023

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

update

What is the current behavior?

target frameworks incorrectly set to netx.0-windows

What is the new behavior?

update targets to netx.0-windows10.0.17763.0 remove unsupported Android targets.

What might this PR break?

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f63a155) 74.06% compared to head (e26f42e) 69.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1065      +/-   ##
==========================================
- Coverage   74.06%   69.52%   -4.55%     
==========================================
  Files          95       95              
  Lines        5530     4600     -930     
  Branches      632      632              
==========================================
- Hits         4096     3198     -898     
+ Misses       1230     1196      -34     
- Partials      204      206       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman merged commit fabbac5 into main Nov 17, 2023
2 of 3 checks passed
@ChrisPulman ChrisPulman deleted the CP_UpdateTargets branch November 17, 2023 23:19
Copy link

github-actions bot commented Dec 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants