Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Avalonia - ReactiveUI.Avalonia.* to Splat.Avalonia.* #1050

Merged
merged 4 commits into from
Sep 2, 2023

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Update

What is the current behavior?

ReactiveUI.Avalonia does not follow solution names of Splat.

What is the new behavior?

Rename ReactiveUI.Avalonia.* to Splat.Avalonia.*
Remove ReactiveUi.Avalonia
Rename Avalonia Tests

What might this PR break?

Packages now have different names, ReactiveUi.Avalonia no longer exists.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Rename ReactiveUI.Avalonia.* to Splat.Avalonia.*
Remove ReactiveUi.Avalonia
Rename Avalonia Tests
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 84.90% and project coverage change: -0.51% ⚠️

Comparison is base (12f241f) 75.45% compared to head (e9c4ff8) 74.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
- Coverage   75.45%   74.95%   -0.51%     
==========================================
  Files          93       95       +2     
  Lines        4387     4511     +124     
==========================================
+ Hits         3310     3381      +71     
- Misses       1077     1130      +53     
Files Changed Coverage Δ
....AppCenter/AppCenterFeatureUsageTrackingSession.cs 85.18% <ø> (ø)
src/Splat.AppCenter/AppCenterViewTracking.cs 0.00% <ø> (ø)
.../ApplicationInsightsFeatureUsageTrackingSession.cs 84.84% <ø> (ø)
src/Splat.Autofac/AutofacDependencyResolver.cs 81.91% <ø> (ø)
src/Splat.Common.Test/ViewThatShouldNotLoad.cs 25.00% <ø> (ø)
src/Splat.Drawing/Bitmaps/BitmapLoaderException.cs 0.00% <ø> (ø)
src/Splat.Drawing/Colors/SplatColor.cs 81.66% <ø> (ø)
src/Splat.Drawing/DefaultPlatformModeDetector.cs 0.00% <ø> (ø)
src/Splat.Drawing/Platforms/ReflectionStubs.cs 0.00% <ø> (ø)
.../Platforms/ServiceLocationDrawingInitialization.cs 0.00% <ø> (ø)
... and 57 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpvreony
Copy link
Member

dpvreony commented Sep 1, 2023

when it's released can someone with nuget access deprecate the old package and mark this as the replacement?

dpvreony
dpvreony previously approved these changes Sep 1, 2023
@dpvreony dpvreony self-requested a review September 1, 2023 23:38
@dpvreony dpvreony dismissed their stale review September 1, 2023 23:39

spotted issue

Copy link
Member

@dpvreony dpvreony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the folder names could do with being tweaked

@ChrisPulman
Copy link
Member Author

when it's released can someone with nuget access deprecate the old package and mark this as the replacement?

I understand the original packages have already been unlisted.

@ChrisPulman
Copy link
Member Author

the folder names could do with being tweaked

I will update the folder names in the morning, thank you.

@ChrisPulman ChrisPulman dismissed dpvreony’s stale review September 2, 2023 04:01

Completed changes as requested

@ChrisPulman ChrisPulman merged commit 66be871 into main Sep 2, 2023
2 of 3 checks passed
@ChrisPulman ChrisPulman deleted the UpdateAvalonia branch September 2, 2023 04:01
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants