Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xml documentation to exposed methods and classes. #1275

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

laurentksh
Copy link
Contributor

@laurentksh laurentksh commented Nov 10, 2021

What kind of change does this PR introduce?

Xml Docs on publicly exposed classes and methods.

What is the current behavior?

Most of the classes and methods you would use when using Refit have no Xml docs. Related issue: #1274

What is the new behavior?

Developers using the library will now see comments when typing a class or method name, hovering over them, etc.

What might this PR break?
I can't see how adding comments could break something so nothing afaik.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features). Checked but doesn't apply to this PR.
  • Docs have been added / updated (for bug fixes / features)

Other information:

Let me know if I have missed something or if you see a comment that should be worded differently/is wrong !

-Added comments for ApiResponse.
-Added comments for most of the attributes.
-Added comments for RestService.
-Added comments to MultipartItems.
-Added comments to Refit settings.
-Added comments to the IHttpContentSerializer interface.
@clairernovotny clairernovotny merged commit 569108a into reactiveui:main Jan 19, 2022
@clairernovotny
Copy link
Member

Thanks!

@laurentksh laurentksh deleted the add-xmldocs branch January 19, 2022 15:06
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants