-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change folder path to avoid implicit NuGet inclusions #1222
Conversation
Yeah it appears that any reference to this:
Generates exceptions at build time. I am curious on why removing it still loads it into That is, based on my understanding, the source generator generates the class files, which are then picked up by the traditional MSBuild process during build. The MSBuild process does not need to reference the above, correct? Still trying to understand things here. :) |
Should this be merged? |
I'm going to go with yes :) I was confused by the close/reopen. |
Build had issues the first time; close/reopen triggered a new one. |
Woohoo... I can confirm that this works like a champ now with I appreciate the dedication to ensuring a high level of quality to your work out there. 👍🙏 |
@sharwell should I release this as stable? |
@clairernovotny the specific risk is as follows:
All other potentially problematic cases should consistently use the old implementation (Roslyn 3.8 APIs) during builds, so even if there are bugs in the Roslyn 4.0 portion it should not manifest in the build outputs. Once confidence is built in the Roslyn 4.0 implementation, we can update the integration to leverage upcoming VBCSCompiler support for incrementally running source generators during builds. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
@Mike-E-angelo I'm hoping we can use something like this PR to avoid needing to move these files completely outside the
analyzers
folder.Fixes #1216 (comment)