Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #3700 Maui Activation fails #3703

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Fix for #3700 Maui Activation fails #3703

merged 2 commits into from
Dec 31, 2023

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Fix for #3700

What is the current behavior?

Maui Activation fails.

What is the new behavior?

Maui Activation updated to include all relevant types

What might this PR break?

none expected

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Maui Activation updated to include all relevant types
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0db5167) 58.37% compared to head (056711c) 58.37%.
Report is 1 commits behind head on main.

❗ Current head 056711c differs from pull request most recent head 5fefc73. Consider uploading reports for the commit 5fefc73 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3703   +/-   ##
=======================================
  Coverage   58.37%   58.37%           
=======================================
  Files         160      160           
  Lines        5776     5776           
  Branches     1029     1029           
=======================================
  Hits         3372     3372           
  Misses       2015     2015           
  Partials      389      389           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman changed the title FIx for #3700 Maui Activation fails Fix for #3700 Maui Activation fails Dec 31, 2023
@ChrisPulman ChrisPulman enabled auto-merge (squash) December 31, 2023 19:56
@ChrisPulman ChrisPulman merged commit 845fb4d into main Dec 31, 2023
1 check passed
@ChrisPulman ChrisPulman deleted the CP_FixFor3700 branch December 31, 2023 20:16
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants