-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for ChangeSetMergeTracker so that it correctly works with Value Types #940
Merged
dwcullop
merged 7 commits into
reactivemarbles:main
from
dwcullop:bugfix/referenceequals-breaks-value-types
Sep 16, 2024
Merged
Fix for ChangeSetMergeTracker so that it correctly works with Value Types #940
dwcullop
merged 7 commits into
reactivemarbles:main
from
dwcullop:bugfix/referenceequals-breaks-value-types
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwcullop
changed the title
Fixes ChangeSetMergeTracker so that it correctly works with Value Types
Fix for ChangeSetMergeTracker so that it correctly works with Value Types
Sep 6, 2024
erri120
reviewed
Sep 6, 2024
Al12rs
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump, for rebase and review, feedback above seems to have been addressed
JakenVeina
approved these changes
Sep 12, 2024
Sorry I was on vacation the past 10 days. It will now just use the given comparer or EqualityComparer.Default (if not provided). |
JakenVeina
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ReferenceEquals
breaks value types #931 by fixingChangeSetMergeTracker
(the basis for multiple operators includingMergeManyChangeSets
,MergeChangeSets
, andTransformManyAsync
)ReferenceEquals
withEqualityComparer<T>.Default.Equals
ReferenceEquals
is explicitly needed (which will gracefully handle value types)Other Fixes
ToObservableOptional
with a more efficient implementation that does not useReferenceEquals