Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransformOnRefresh option for TransformWithInlineUpdate. #875

Merged
merged 4 commits into from
Mar 17, 2024

Conversation

RolandPheasant
Copy link
Collaborator

Transform allows the option to apply the a transform when a refresh even is received.

This PR is to add this feature to TransformWithInlineUpdate

@JakenVeina
Copy link
Collaborator

Needs an update to the API file.

Copy link
Member

@dwcullop dwcullop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me, but you should decide on the breaking change vs. additional overload issue. Either way, the API text file needs updating.

src/DynamicData/Cache/ObservableCacheEx.cs Outdated Show resolved Hide resolved
@JakenVeina JakenVeina added enhancement breaking change Items that contain a breaking change to the codebase labels Mar 13, 2024
@RolandPheasant
Copy link
Collaborator Author

The changes look fine to me, but you should decide on the breaking change vs. additional overload issue. Either way, the API text file needs updating.

@dwcullop I added the additional overloads instead of using optional params

@RolandPheasant
Copy link
Collaborator Author

Needs an update to the API file.

@JakenVeina done

@RolandPheasant RolandPheasant merged commit e8c905a into main Mar 17, 2024
1 check passed
@RolandPheasant RolandPheasant deleted the feature/transforminline-onrefresh branch March 17, 2024 15:12
Copy link

github-actions bot commented Apr 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change Items that contain a breaking change to the codebase enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants