Feature: Group by Dynamic Selector Function #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix Unit Tests - Remove extra locker object
JakenVeina
requested changes
Feb 13, 2024
src/DynamicData.Tests/Cache/MergeManyChangeSetsCacheSourceCompareFixture.cs
Show resolved
Hide resolved
JakenVeina
approved these changes
Feb 13, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #848 by providing new overloads for the
Groupoperator that allow the user to supply aIObservable<Func<TObject, TKey, TGroupKey>>so that the function that is used to obtain the GroupKey can change dynamically. When a new value is supplied, a new GroupKey will be obtained for each item, and if the GroupKey has changed, the item will be moved to the new Group.Also allows for an optional
IObservable<Unit>parameter that will force the current GroupKey selector to be re-applied to all the items.Issues
This operator also suffers from #851. I will submit another PR that fixes both operators at the same time.