-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExpireAfter Testing Rework #821
Conversation
|
||
// Covers https://github.com/reactivemarbles/DynamicData/issues/716 | ||
[Fact(Skip = "Existing defect, removals are skipped when scheduler invokes early")] | ||
public void SchedulerIsInaccurate_RemovalsAreNotSkipped() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the test that leverages the new TestScheduler
class.
Also, benchmarks, for comparison later: ExpireAfter_Cache_ForSource
ExpireAfter_Cache_ForStream
ExpireAfter_List
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is clearly very well considered testing. I do not understand every detail atm, but the tests pass and that's good enough for me.
In the near future I will step into the tests to familiarise myself with the fine grained details.
@RolandPheasant if you ever have the time, hit me up in slack and we can chat about it live. |
…mprove functional coverage and cover various existing defects.
9b7c040
to
a6a60d7
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Reworked testing for all versions of the
ExpireAfter
operator, to improve functional coverage and cover various existing defects.This will support the effort to fix #716.