DisposeMany() Rework #755
Merged
DisposeMany() Rework #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also appears to fix #668 based on the initial reproduction. |
…erform disposal after downstream operations have processed, rather than before, since the operator cannot guarantee that disposal is safe, when downstream consumers may still need to make use of these disposable items, in order to process removals. Also fixed a bug within both versions of the `.SubscribeMany()` operator, where errors were not being properly propagated through the stream, and instead could bubble up to stream inputs. Also fixed a bug within the cache version of `.MergeMany()` that allowed an internally-used subject to be disposed, without cleaning up all subscriptions that may later make use of it.
JakenVeina
force-pushed
the
dispose-many-rework
branch
from
a1880d0 to
8266846
Compare
…any()` operators.
|
For reference, performance is ever so slightly improved, with these changes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
==========================================
+ Coverage 64.74% 65.46% +0.72%
==========================================
Files 226 227 +1
Lines 11459 11091 -368
Branches 2334 2294 -40
==========================================
- Hits 7419 7261 -158
+ Misses 3083 2889 -194
+ Partials 957 941 -16 ☔ View full report in Codecov by Sentry. |
RolandPheasant
approved these changes
Nov 16, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked the
.DisposeMany()operator for both caches and lists to perform disposal after downstream operations have processed, rather than before, since the operator cannot guarantee that disposal is safe, when downstream consumers may still need to make use of these disposable items, in order to process removals.Also fixed a bug within both versions of the
.SubscribeMany()operator, where errors were not being properly propagated through the stream, and instead could bubble up to stream inputs.Also fixed a bug within the cache version of
.MergeMany()that allowed an internally-used subject to be disposed, without cleaning up all subscriptions that may later make use of it.Resolves #732