Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add overload of TransformMany that works with child instances of IObservableCache #689

Merged
merged 6 commits into from
May 22, 2023
Merged

feature: Add overload of TransformMany that works with child instances of IObservableCache #689

merged 6 commits into from
May 22, 2023

Conversation

John-MartinMalone
Copy link
Contributor

@John-MartinMalone John-MartinMalone commented Mar 4, 2023

Add overload of TransformMany that works with child instances of IObservableCache

Copy link
Collaborator

@RolandPheasant RolandPheasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing, can you update the version found here:

version.json#L2

to 7.14

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #689 (fb83606) into main (e431a5d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
+ Coverage   71.86%   71.90%   +0.04%     
==========================================
  Files         216      216              
  Lines       10876    10893      +17     
==========================================
+ Hits         7816     7833      +17     
  Misses       3060     3060              
Impacted Files Coverage Δ
src/DynamicData/Cache/Internal/TransformMany.cs 97.29% <100.00%> (+0.32%) ⬆️
src/DynamicData/Cache/ObservableCacheEx.cs 50.65% <100.00%> (+0.04%) ⬆️

@glennawatson glennawatson changed the title Add overload of TransformMany that works with child instances of IObservableCache feature: Add overload of TransformMany that works with child instances of IObservableCache May 10, 2023
@glennawatson
Copy link
Member

@RolandPheasant I've updated the version indicator for @John-MartinMalone

@glennawatson glennawatson merged commit 9af334c into reactivemarbles:main May 22, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants