-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Adds OnItemRefreshed extension method for SourceList and SourceCache #580
Conversation
Probably worth editing the description of the PR with some more details. Just so @RolandPheasant can tell what's going on and also users checking the release notes. |
I noticed the PR template disappeared, apologies for that. Will fix that up but thanks for the edit to make it more clear. |
just some compile errors based on our analyzers.
Also thinking about it I think @RolandPheasant would love some unit tests for this new functionality. |
Added unit test for the new refreshed method and also added equivalent missing tests for List |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and thanks for the contribution.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Adds OnItemRefreshed extension method for SourceList and SourceCache.
Implementation comes from the way OnItemAdded and OnItemRemoved methods are implemented.
Function:
Executes defined action, when item with ChangeReason.Refreshed comes through the pipeline.