Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Adds OnItemRefreshed extension method for SourceList and SourceCache #580

Merged
merged 5 commits into from
Apr 27, 2022

Conversation

tomasfil
Copy link
Contributor

@tomasfil tomasfil commented Apr 26, 2022

Adds OnItemRefreshed extension method for SourceList and SourceCache.

Implementation comes from the way OnItemAdded and OnItemRemoved methods are implemented.

Function:
Executes defined action, when item with ChangeReason.Refreshed comes through the pipeline.

@glennawatson
Copy link
Member

Probably worth editing the description of the PR with some more details. Just so @RolandPheasant can tell what's going on and also users checking the release notes.

@tomasfil tomasfil changed the title OnItemRefreshed Adds OnItemRefreshed extension method for SourceList and SourceCache Apr 27, 2022
@glennawatson glennawatson changed the title Adds OnItemRefreshed extension method for SourceList and SourceCache feature: Adds OnItemRefreshed extension method for SourceList and SourceCache Apr 27, 2022
@glennawatson
Copy link
Member

I noticed the PR template disappeared, apologies for that. Will fix that up but thanks for the edit to make it more clear.

@glennawatson
Copy link
Member

just some compile errors based on our analyzers.

Error: D:\a\DynamicData\DynamicData\src\DynamicData\Cache\ObservableCacheEx.cs(2830,171): error RCS1037: Remove trailing white-space. [D:\a\DynamicData\DynamicData\src\DynamicData\DynamicData.csproj]
Error: D:\a\DynamicData\DynamicData\src\DynamicData\Cache\ObservableCacheEx.cs(2830,171): error SA1028: Code should not contain trailing whitespace [D:\a\DynamicData\DynamicData\src\DynamicData\DynamicData.csproj]
Error: D:\a\DynamicData\DynamicData\src\DynamicData\Cache\ObservableCacheEx.cs(2830,171): error RCS1037: Remove trailing white-space. [D:\a\DynamicData\DynamicData\src\DynamicData\DynamicData.csproj]
Error: D:\a\DynamicData\DynamicData\src\DynamicData\Cache\ObservableCacheEx.cs(2830,171): error SA1028: Code should not contain trailing whitespace [D:\a\DynamicData\DynamicData\src\DynamicData\DynamicData.csproj]
Error: D:\a\DynamicData\DynamicData\src\DynamicData\Cache\ObservableCacheEx.cs(2830,171): error RCS1037: Remove trailing white-space. [D:\a\DynamicData\DynamicData\src\DynamicData\DynamicData.csproj]
Error: D:\a\DynamicData\DynamicData\src\DynamicData\Cache\ObservableCacheEx.cs(2830,171): error SA1028: Code should not contain trailing whitespace [D:\a\DynamicData\DynamicData\src\DynamicData\DynamicData.csproj]
Error: D:\a\DynamicData\DynamicData\src\DynamicData\Cache\ObservableCacheEx.cs(2830,171): error RCS1037: Remove trailing white-space. [D:\a\DynamicData\DynamicData\src\DynamicData\DynamicData.csproj]
Error: D:\a\DynamicData\DynamicData\src\DynamicData\Cache\ObservableCacheEx.cs(2830,171): error SA1028: Code should not contain trailing whitespace [D:\a\DynamicData\DynamicData\src\DynamicData\DynamicData.csproj]

Also thinking about it I think @RolandPheasant would love some unit tests for this new functionality.

@tomasfil
Copy link
Contributor Author

Added unit test for the new refreshed method and also added equivalent missing tests for List

Copy link
Collaborator

@RolandPheasant RolandPheasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and thanks for the contribution.

@glennawatson glennawatson merged commit 113af1b into reactivemarbles:main Apr 27, 2022
@tomasfil tomasfil deleted the OnItemRefreshed branch April 27, 2022 09:15
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants