Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure comparer changed is subscribed to before data changed for list #476

Merged
merged 1 commit into from
May 19, 2021

Conversation

RolandPheasant
Copy link
Collaborator

Fixes #473

@codecov-commenter
Copy link

Codecov Report

Merging #476 (6b88f5c) into main (c6234b0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   71.45%   71.45%           
=======================================
  Files         214      214           
  Lines       10655    10655           
=======================================
  Hits         7613     7613           
  Misses       3042     3042           
Impacted Files Coverage Δ
src/DynamicData/List/Internal/Sort.cs 89.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6234b0...6b88f5c. Read the comment docs.

@RolandPheasant RolandPheasant merged commit c1870d3 into main May 19, 2021
@RolandPheasant RolandPheasant deleted the ListSortIssue branch May 19, 2021 10:33
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] Exception when using .Sort with comparerChanged overload and AddRange
3 participants