Implementation of i18n namespaces support #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added `ns` field to translations schema; - `loadCoreTranslations` now lookup all packages with assets for translation files; - import now support namespaces; i18next now receives correct objects with namespaces; - added `ns` to all translation files;
newsiberian
changed the title
|
Approved |
brent-hoover
added a commit
that referenced
this pull request
Mar 22, 2016
Implementation of i18n namespaces support
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of namespaces support for
reaction-i18n.To make it works with import, we have to add new
nsfield toTranslationsschema. Also, it is now always correctly loadentranslations within publication, don't know why, but this happens only on first load after reset and then works fine.Package creators will need to copy directory structure to make this work:
private/data/i18n