feat/promotions create auto increment function for generating auto-increment Ids #6645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
|
aldeed
reviewed
Nov 10, 2022
| export const Sequence = new SimpleSchema({ | ||
| shopId: String, | ||
| entity: String, | ||
| value: SimpleSchema.Integer |
There was a problem hiding this comment.
Consider adding min: 0 validation
There was a problem hiding this comment.
@aldeed Could not think of what to write tests for since it relies to heavily on the db which would need to mocked
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
…ment-id Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
vanpho93
reviewed
Nov 14, 2022
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
vanpho93
reviewed
Nov 14, 2022
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
vanpho93
approved these changes
Nov 14, 2022
vanpho93
pushed a commit
that referenced
this pull request
Apr 24, 2023
…-auto-increment-id feat/promotions create auto increment function for generating auto-increment Ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves reactioncommerce/kinetic#107
Impact: minor
Type: feature
Issue
Unlike most SQL databases Mongo does not have a built in function for creating auto-incrementing IDs
Solution
Using
findOneAndUpdateand$incis a fully atomic operation that is not subject to race-conditions and thus works as an equivalent. Please read that again for commenting, nerds.Breaking changes
None