-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint Configration #93
Conversation
[ci skip] [skip ci]
Co-authored-by: codefactor-io <support@codefactor.io>
Still Chages Required in below files:
|
[ci skip] [skip ci]
[ci skip] [skip ci]
|
||
// transpiling and copy js | ||
process.stdout.write('Transpiling js with babel... \n'); | ||
const jsResult = await exec(`babel ${sourceDir} --out-dir ${jsTarget} --ignore "${excludedFolders.map(folder => path.join(sourceDir, folder)).join(',')}"`); | ||
await exec(`babel ${sourceDir} --out-dir ${jsTarget} --ignore "${excludedFolders.map(folder => path.join(sourceDir, folder)).join(',')}"`); |
Check warning
Code scanning / CodeQL
Shell command built from environment values
2. Remove duplication from dndContext File
let { slotId, slotName } = resourceEvents; | ||
let action = 'New'; | ||
const isEvent = type === DnDTypes.EVENT; | ||
if (isEvent) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical blocks of code found in 2 locations. Consider refactoring.
newEnd = localeDayjs(newStart) | ||
.add(localeDayjs(event.end).diff(localeDayjs(event.start)), 'ms') | ||
const isEvent = type === DnDTypes.EVENT; | ||
if (isEvent) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical blocks of code found in 2 locations. Consider refactoring.
Code Climate has analyzed commit e90a956 and detected 27 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Hey, how is going? |
Configuration is done need to fix eslint errors |
I am busy now so may take more time, if you have time please continue |
Unfortunately these days I am really busy, but I will try to find some time. |
No problem, thanks |
No description provided.