Apply fixes from CodeFactor #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can see that is just adding the ESlint rules. We can achieve the same functionality if we add ESlint rules and Prettier formatting. Then we will not need to use 3rd party websites like this one. P.S. I agree with the changes |
|
What all configuration do we did default eslint with airbnb one or which one |
|
airbnb with react |
|
Will you configure it or shall I? |
|
Today is Monday and I am really busy, if you want to be done, do it. If not, I can make it later this week. |
|
OK, I will start working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request applies style fixes from code review by CodeFactor.
For more information, click here.