This repository has been archived by the owner on Jan 30, 2021. It is now read-only.
Use nativeEvent.layout in onLayout, instead of buggy measureInWindow #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android with Expo (and its default translucent statusbar) the
touchesTop
detection is incorrect. This is because
measureInWindow
has a bug that makesits behaviour inconsistent with other platforms:
facebook/react-native#19497.
This PR replaces the usage of measureInWindow with the use of
nativeEvent.layout (which is the workaround provided in the issue linked
above). This makes
touchesTop
detection work for android correctly soforceInset={{ top: 'always' }}
doesn't have to be provided anymore.