Support repeatIntervals of minute, hour, day, week, month, and year in addNotificationRequest() #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar) parameter for addNotificationRequest(). Also fixes bug with current implementation where notification would not repeat daily with repeats= true as per the documentation.
…ure function of all use cases. Supports repeating by year, month, week, day, hour, minute, non-repeating, and immediate delivery. The "repeats" parameter in addNotificationRequest() is effectively redundant and replaced by "repeatInterval" however the documented behaviour of "repeats" has been retained to ensure backwards compatibility, even though it didn't previously work.
|
+1 🎉 I would love to see this merged. This would be very helpful! |
|
@jamesxabregas thank you so much for the suggestion! along with review for #268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds logic to enable
addNotificationRequest()to have repeating logic simmilar to that provided byscheduleLocalNotification()which is deprecated. addNotificationRequest() now supports arepeatIntervalparameter with valuesminute,hour,day,week,month,year.This pull request also fixes a bug with
addNotificationRequest()that meant that the notification request didn't repeat daily as documented even if therepeatsparameter was set totrue(it was configured in a way that meant it would only fire once).