Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new React Native new architecture (TurboModules/Fabric) #162

Closed
tom-sherman opened this issue Jun 23, 2022 · 7 comments · Fixed by #221
Closed

Support new React Native new architecture (TurboModules/Fabric) #162

tom-sherman opened this issue Jun 23, 2022 · 7 comments · Fixed by #221
Labels
hacktoberfest

Comments

@tom-sherman
Copy link

tom-sherman commented Jun 23, 2022 •
edited
Loading

See https://reactnative.dev/docs/new-architecture-library-intro

https://reactnative.dev/blog/2022/06/16/resources-migrating-your-react-native-library-to-the-new-architecture
@tom-sherman tom-sherman mentioned this issue Jun 23, 2022
Closed
@tom-sherman tom-sherman changed the title Support new React Native new architecture Support new React Native new architecture (TurboModules/Fabric) Jun 23, 2022
@unfernandito
Copy link

Hi @tom-sherman

I'm working in this support #164

@unfernandito
Copy link

@tom-sherman currently, fabric for android is full working, you can try my fork if you want.

iOS Fabric is barely supported in my fork, not crash but right now I'm stuck with this issue when you try to use the lib:

image

I guess the issue is in the UIManager and how it works under fabric architecture but I'm pretty lost, I'll continue searching for a solution

@hansdesmedt
Copy link

I started a new discussion about this issue

reactwg/react-native-new-architecture#80

@hansdesmedt
Copy link

hey @unfernandito I created a PR on your PR, can you check and merge both into this lib? Thx!

issues fixed:

  • fix build for android
  • fix masked view for iOS fabric build

unfernandito#3

@hansdesmedt
Copy link

or I can create a PR with the changes of @unfernandito and mine directly into this repo?

@unfernandito
Copy link

Hey, yes i Will check your pr

@aleksey-mukho
Copy link

Any updates?

@dcalhoun dcalhoun mentioned this issue Aug 4, 2023
Open
30 tasks
mateusz1913 added a commit to mateusz1913/masked-view that referenced this issue Mar 24, 2024
@mateusz1913
feat(react-native-masked-view#162): fabric support
8843834 
- add JS Flow spec
- make android viewmanager to conform to codegen-ed specs
- add codegen-ed spec to make viewmanager work also in old arch
- use install_module_dependencies in the podspec to install deps on both new and old architectures
- add subclass of RCTViewComponentView
- use fabric implementation when RCT_NEW_ARCH_ENABLED flag is true
- set RN peerDependency to be version >= 0.71
mateusz1913 added a commit to mateusz1913/masked-view that referenced this issue Mar 24, 2024
@mateusz1913
feat(react-native-masked-view#162): bump RNTA to v3, bump RN to v0.73
083f3e5
mateusz1913 added a commit to mateusz1913/masked-view that referenced this issue Mar 24, 2024
@mateusz1913
feat(react-native-masked-view#162): fabric support
fc24502 
- add JS Flow spec
- make android viewmanager to conform to codegen-ed specs
- make android viewmanager extend ReactViewManager instead of ViewGroupManager
- add codegen-ed spec to make viewmanager work also in old arch
- use install_module_dependencies in the podspec to install deps on both new and old architectures
- add subclass of RCTViewComponentView
- use fabric implementation when RCT_NEW_ARCH_ENABLED flag is true
- set RN peerDependency to be version >= 0.71
mateusz1913 added a commit to mateusz1913/masked-view that referenced this issue Mar 24, 2024
@mateusz1913
feat(react-native-masked-view#162): bump RNTA to v3, bump RN to v0.73…
01640a5 
…, add pointerEvents example
mateusz1913 added a commit to mateusz1913/masked-view that referenced this issue Mar 24, 2024
@mateusz1913
feat(react-native-masked-view#162): bump RNTA to v3, bump RN to v0.73…
6771d97 
…, add pointerEvents example
@mateusz1913 mateusz1913 mentioned this issue Mar 24, 2024
Merged
brentvatne pushed a commit that referenced this issue Apr 1, 2024
@mateusz1913
feat(#162): fabric support (#221)
b5dc9d0 
* feat(#162): fabric support

- add JS Flow spec
- make android viewmanager to conform to codegen-ed specs
- make android viewmanager extend ReactViewManager instead of ViewGroupManager
- add codegen-ed spec to make viewmanager work also in old arch
- use install_module_dependencies in the podspec to install deps on both new and old architectures
- add subclass of RCTViewComponentView
- use fabric implementation when RCT_NEW_ARCH_ENABLED flag is true
- set RN peerDependency to be version >= 0.71

* feat(#162): bump RNTA to v3, bump RN to v0.73, add pointerEvents example
brentvatne added a commit that referenced this issue Apr 1, 2024
@brentvatne
Revert "feat(#162): fabric support (#221)"
bfdf67d 
This reverts commit b5dc9d0.
brentvatne added a commit that referenced this issue Apr 1, 2024
@brentvatne
Revert "feat(#162): fabric support (#221)" (#222)
a6e0d3d 
This reverts commit b5dc9d0.
mateusz1913 added a commit to mateusz1913/masked-view that referenced this issue Apr 3, 2024
@mateusz1913
feat(react-native-masked-view#162): fabric support
9cd0ddb 
- add JS Flow spec
- make android viewmanager to conform to codegen-ed specs
- make android viewmanager extend ReactViewManager instead of ViewGroupManager
- add codegen-ed spec to make viewmanager work also in old arch
- use install_module_dependencies in the podspec to install deps on both new and old architectures
- add subclass of RCTViewComponentView
- use fabric implementation when RCT_NEW_ARCH_ENABLED flag is true
- set RN peerDependency to be version >= 0.71
mateusz1913 added a commit to mateusz1913/masked-view that referenced this issue Apr 3, 2024
@mateusz1913
feat(react-native-masked-view#162): bump RNTA to v3, bump RN to v0.73…
4458ac4 
…, add pointerEvents example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#162): fabric support mateusz1913/masked-view
5 participants
@hansdesmedt @unfernandito @Naturalclar @tom-sherman @aleksey-mukho