fix(android): custom maker performance improvements when view tracking #4969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jared-ca
commented
Feb 15, 2024
|
@jan-kozinski @mateki0 can you guys please take the time to review / test |
|
I think it works as it should. Without this fix adding about 25 markers caused fps drop to ~1 and sometimes map is freezed on my device. With it it still lose some fps but it's much better and map is usable. I have also checked other Marker related examples and it looks like everything is fine (Animated marker position, Postion marker wtih z index, Massive custom markers). However with tracksViewChanges={false} it works fine with and without fix. But we probably don't want to put this limitation on users longer. |
mateki0
approved these changes
Feb 28, 2024
jan-kozinski
approved these changes
Mar 3, 2024
jan-kozinski
approved these changes
Mar 10, 2024
salah-ghanim
approved these changes
Mar 10, 2024
react-native-maps-bot
pushed a commit
that referenced
this pull request
Mar 10, 2024
## [1.11.1](v1.11.0...v1.11.1) (2024-03-10) ### Bug Fixes * **android:** custom maker performance improvements when view tracking ([#4969](#4969)) ([f30c9d7](f30c9d7))
|
🎉 This PR is included in version 1.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Super-CodeKing
added a commit
to Super-CodeKing/react_native_map
that referenced
this pull request
Apr 26, 2024
## [1.11.1](react-native-maps/react-native-maps@v1.11.0...v1.11.1) (2024-03-10) ### Bug Fixes * **android:** custom maker performance improvements when view tracking ([#4969](react-native-maps/react-native-maps#4969)) ([f30c9d7](react-native-maps/react-native-maps@f30c9d7))
fairskyDev0201
pushed a commit
to fairskyDev0201/react-native-maps
that referenced
this pull request
Apr 29, 2024
## [1.11.1](react-native-maps/react-native-maps@v1.11.0...v1.11.1) (2024-03-10) ### Bug Fixes * **android:** custom maker performance improvements when view tracking ([#4969](react-native-maps/react-native-maps#4969)) ([f30c9d7](react-native-maps/react-native-maps@f30c9d7))
DavidLee0501
added a commit
to DavidLee0501/React-Native-Map
that referenced
this pull request
Aug 12, 2024
## [1.11.1](react-native-maps/react-native-maps@v1.11.0...v1.11.1) (2024-03-10) ### Bug Fixes * **android:** custom maker performance improvements when view tracking ([#4969](react-native-maps/react-native-maps#4969)) ([f30c9d7](react-native-maps/react-native-maps@f30c9d7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was identified by profiling the app when the performance dropped to 10FPS.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
#4968
How did you test this PR?
This change was tested on a Pixel 7 Pro using the sample code from the attached issue. With this change in place adding 20 markers sequentially has no performance impact and the app could maintain 120fps. ( Without the change the FPS dropped to about 10 ).
I also added some code to change the contents of the custom view and verified that it was updating on the map.