Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac os support #612

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

danilaplee
Copy link

@danilaplee danilaplee commented Dec 21, 2022

Screenshot 2022-12-21 at 16 28 25

Screenshot 2022-12-21 at 16 51 30

Summary

OSX support is critical for my product

Test Plan

tested on OSX

What's required for testing (prerequisites)?

use base functionality

What are the steps to reproduce (after prerequisites)?

use base functionality

Compatibility

OS Implemented
iOS
macOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

@danilaplee
Copy link
Author

can anyone test this one in ios, because i currently don't have a stable ios build of my app

I have tested only on mac os

@danilaplee danilaplee changed the title barebones mac os support mac os support Dec 21, 2022
@chriscarex
Copy link

chriscarex commented Dec 30, 2022

I managed to test it on the iOS emulator and seems to work. See screenshots attached - let me know if more info needed

@danilaplee
Copy link
Author

@chriscarex thank you so much, next I'am gonna add support for the web with a new merge request

@vonovak
Copy link
Collaborator

vonovak commented Jan 2, 2023

hello and thanks for the PR
I have a lot on my plate right now and am taking a vacation soon, I think I'll be able to take a proper look at the end of the month, thank you

@danilaplee
Copy link
Author

@vonovak cool thanks

@danilaplee
Copy link
Author

@vonovak if anything worries you about my pr please write the changes i should make and dont close the pr, I will make the changes because i'am building my open source project on top of your stuff and i would like it to be used properly as you intended and i'am open to code style changes for sure, especially linting

@vonovak
Copy link
Collaborator

vonovak commented Mar 13, 2023

Hello and thank you for your PR!

Sorry for taking so long to get back to you.

First, how can I test this in the example app? Does this use Mac catalyst? Is it intended for react-native-macos?

Thank you

@keenan-v1
Copy link

I am actively developing a react-native-macos application and would be willing to be a test dummy for this. Can we get the PR merged up to latest and I can give it a go in my project?

@atiqulislamwb
Copy link

Hi,
Now, does this package support mac os ? i am trying but gives me error..

@danishshaik
Copy link

I also have a use case for this in my react-native-macos app. Any chance we can get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants