[dist] update most dependencies #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielSanudo
suggested changes
Jul 30, 2019
| ```gradle | ||
| include ':react-native-datetimepicker' | ||
| project(':react-native-datetimepicker').projectDir = new File(rootProject.projectDir, '../node_modules/@react-native-community/datetimepicker/android') | ||
| ``` | ||
|
|
||
| 2. Add into `android/gradle.properties`: |
There was a problem hiding this comment.
This is not needed anymore? useAndroidX and enableJetifier?
There was a problem hiding this comment.
This is now added by default by a React app, see https://react-native-community.github.io/upgrade-helper/?from=0.59.3&to=0.60.4 and scroll down to the file
There was a problem hiding this comment.
More background on the React@0.60 upgrade: https://facebook.github.io/react-native/blog/2019/07/03/version-60#androidx-support
DanielSanudo
approved these changes
Jul 31, 2019
3rd-Eden
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update dependencies, specifically latest React Native.
Test Plan
What's required for testing (prerequisites)?
Flow, Eslint and Jest all work
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
- [ ] I added the documentation inREADME.mdCHANGELOG.md- [ ] I updated the typed files (TS and Flow)- [ ] I added a sample use of the API in the example project (example/App.js)