Add ability to specify custom app package for Android code diffs e.g. org.myorg #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Android Java builds) as well as the app name. Simplified form field state while keeping UI snappy (making use of useDeferredValue). Preferred replaceAll with plain old strings rather than RegExps. Latter probably overkill and harder to read when constructing more elaborate search strings for package substitution code.
smallsaucepan
requested review from
lucasbento,
pvinis and
kelset
as code owners
pvinis
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding functionality to let users specify their own package name (for Android Java builds) as well as the app name.
Simplified form field state while keeping UI snappy (making use of useDeferredValue). Preferred replaceAll with plain old strings rather than RegExps. Latter probably overkill and harder to read when constructing more elaborate search strings for package substitution code.
Resolves issues #339 and #366.
Test Plan
Added some unit tests adjacent to the main function being changed.
Checklist
README.md(if needed)Update to readme not required.