package.json + template.config.js + dependency on @react-native-community/cli #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary for bootstrapping from CLI
The dependency graph looks like this for the iOS Podfile: [@react-native-community/cli-platforms-ios/autolinking.rb] | v [react-native/scripts/react_native_pods.rb] | |-+ def use_react_native!() | + all ./cocoapods/* libraries for codegen | | | v | [@react-native/core-cli-utils/autolinking/ios/link_native_modules.rb] | |-+ def link_native_modules!() | + def list_native_modules!() + def autolink_native_modules!() | v [legacy: native_modules.rb] |-+ def use_native_modules!() We need all of the methods for codegen to work.
|
This might need to depend on the new 14.0.0-alpha. Also how are we going to keep these links current? |
blakef
added a commit
to blakef/cli
that referenced
this pull request
Mar 15, 2024
Instead of native_modules serving `use_native_modules!(config)`, users should now use `autolink_native_modules!()` from autolinking.rb. This is being used in react-native-community/template#7
2 tasks
Yup this is correct and intended.
That's ok if we need it now for working. As soon as 14.0.0 releases, we'll have to update the dependency here.
We'll have to udpate the dependency here as soon as the CLI releases. |
cortinico
approved these changes
Mar 19, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is part of work to remove the dependency on the
@react-native-community/cli-platform-ios/native_modules.rbin thereact-nativepackage. What we want is this:To do this, we have to split apart
native-modules.rbinto:link_native_modules!(a platform concern of injecting PodSpecs into the Xcode workplace build), andlist_native_modules!(module discover is a framework concern. For example the community template depends on config's, whereas something like Expo has gone another route)The impact of this change means that the template now has to explicitly depend on https://npmjs.com/package/@react-native-community/cli which transitively includes both platform specific dependencies:
Changes used
Here's the old and new dependency graph:
