Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release.yaml #66

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Update release.yaml #66

merged 2 commits into from
Oct 2, 2024

Conversation

blakef
Copy link
Collaborator

@blakef blakef commented Oct 2, 2024 •
edited
Loading

Summary:

  1. Fixed a typo in the shell script
  2. Allow the release release workflow to continue if there are no git changes. This can occur if the npm publish step fails. Npm isn't going to let us publish duplicates, so it's safe to try again.

Testing

0.75.4 ran into these issues, this has already been picked onto 0.75-stable and 0.76-stable.

@blakef
Fix: continue attempting release nothing to commit
aa2b1e3 
This can happen if npm publish fails
@blakef blakef merged commit 9efb982 into main Oct 2, 2024
@blakef blakef deleted the fix-release-workflow branch October 2, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

@cipolleschi cipolleschi Awaiting requested review from cipolleschi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blakef @cortinico