Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

0.61.2 Discussion #148

Closed
grabbou opened this issue Oct 2, 2019 · 44 comments
Closed

0.61.2 Discussion #148

grabbou opened this issue Oct 2, 2019 · 44 comments
Labels
backport request Cherry picking a change into an existing release stable Stable version

Comments

@grabbou
Copy link
Member

grabbou commented Oct 2, 2019

Conversations on this thread are limited to 0.61 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.61.2 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

@grabbou grabbou added backport request Cherry picking a change into an existing release stable Stable version labels Oct 2, 2019
@r3nya

This comment has been minimized.

@fungilation

This comment has been minimized.

@grabbou

This comment has been minimized.

@r3nya

This comment has been minimized.

@grabbou

This comment has been minimized.

@fungilation

This comment has been minimized.

@levibuzolic

This comment has been minimized.

@grabbou

This comment has been minimized.

@pvinis

This comment has been minimized.

@blohamen

This comment has been minimized.

@alnorris

This comment has been minimized.

@craftmusic

This comment has been minimized.

@janicduplessis

This comment has been minimized.

@radko93

This comment has been minimized.

@fungilation

This comment has been minimized.

@grabbou
Copy link
Member Author

grabbou commented Oct 10, 2019

Thanks for the requests. I was busy working on the CLI and trying to cut 0.62. in the meantime. I will look into your cherry-pick requests now.

@grabbou

This comment has been minimized.

@grabbou

This comment has been minimized.

@s349856186

This comment has been minimized.

@radeno

This comment has been minimized.

@kennym

This comment has been minimized.

@heroic

This comment has been minimized.

@s349856186

This comment has been minimized.

@WebRom1145

This comment has been minimized.

@sunnylqm

This comment has been minimized.

@WebRom1145

This comment has been minimized.

@sunnylqm

This comment has been minimized.

@piashcse

This comment has been minimized.

@mikehardy

This comment has been minimized.

@kristerkari

This comment has been minimized.

@grabbou

This comment has been minimized.

@grabbou
Copy link
Member Author

grabbou commented Oct 24, 2019

Following up on #148 (comment), I haven't had luck finding a root cause for the Android test failure. I am going to exclude it from this release.

Meanwhile, @radko93 (since you requested it), do have any ideas why this might be happening? I would appreciate your support on that and I am happy to revisit once this is working.

@dulmandakh

This comment has been minimized.

@waqas19921

This comment has been minimized.

@blohamen

This comment has been minimized.

@grabbou

This comment has been minimized.

@grabbou
Copy link
Member Author

grabbou commented Oct 28, 2019

Just finished cherry-picking and tests are on the CI. I had to cherry-pick few more ScrollView related commits in order to merge clearly the requests. Will look in few hours for the CI results and if all goes well, ship it.

@grabbou
Copy link
Member Author

grabbou commented Oct 29, 2019

Releasing 0.61.3 now.

@grabbou grabbou closed this as completed Oct 29, 2019
@grabbou grabbou reopened this Oct 29, 2019
@grabbou
Copy link
Member Author

grabbou commented Oct 29, 2019

I am going to revert a few additional commits.

Please, only request commits for fixes that you have experienced yourself using the release. We are keeping the cherry-picks for critical, blocking issues that happen to you while developing.

Suggesting commits that are fixing something that is not present in this release are slowing down the release process and require cherry-picking additional number of changes (e.g. in case of the two above commits, the original feature commit that introduced the bug).

You can see the history of the branch here: https://github.com/facebook/react-native/commits/0.61-stable

@grabbou
Copy link
Member Author

grabbou commented Oct 29, 2019

For reference, here's the list of commits that is going to go with 0.61.3:

@grabbou grabbou closed this as completed Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport request Cherry picking a change into an existing release stable Stable version
Projects
None yet
Development

No branches or pull requests