fix: Fixed failing to find headers when linked with Pods. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you've linked using react-native link, you will have to rerun the command. If you've linked manually, find your Podfile, and make the following changes: ```diff - pod 'react-native-async-storage', :path => '../node_modules/@react-native-community/async-storage' + pod 'RNCAsyncStorage', :path => '../node_modules/@react-native-community/async-storage' ```
|
That was quick @tido64 Gave this a test try - it fixes the pods issue. Tried with:
Build worked. |
dblazeski
previously approved these changes
Apr 13, 2019
|
Good work! You should also update |
krizzu
previously approved these changes
Apr 13, 2019
|
Thanks @tido64 and everybody, that was quick! |
stigi
approved these changes
Apr 13, 2019
marcosrdz
approved these changes
Apr 14, 2019
krizzu
approved these changes
Apr 14, 2019
krizzu
pushed a commit
that referenced
this pull request
Apr 14, 2019
## [1.3.2](v1.3.1...v1.3.2) (2019-04-14) ### Bug Fixes * failing to find headers when linked with Pods. ([#75](#75)) ([5ab6602](5ab6602))
|
🎉 This PR is included in version 1.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Corey-Peyton
added a commit
to Corey-Peyton/async-storage
that referenced
this pull request
Jul 14, 2021
## [1.3.2](react-native-async-storage/async-storage@v1.3.1...v1.3.2) (2019-04-14) ### Bug Fixes * failing to find headers when linked with Pods. ([#75](react-native-async-storage/async-storage#75)) ([5ab6602](react-native-async-storage/async-storage@5ab6602))
DenisSolution
pushed a commit
to DenisSolution/React-native-async-storage
that referenced
this pull request
Aug 27, 2022
## [1.3.2](react-native-async-storage/async-storage@v1.3.1...v1.3.2) (2019-04-14) ### Bug Fixes * failing to find headers when linked with Pods. ([#75](react-native-async-storage/async-storage#75)) ([5ab6602](react-native-async-storage/async-storage@5ab6602))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Multiple people have reported that RNCAsyncStorage fails to build after #35. See #35 (comment), #73, and #74.
After a little discussion, we agreed to rename the
.podspecand the name of the Pod to be more in line with Apple's naming guidelines and the rest of the community. Unfortunately, this means that the next upgrade will break.I got a little impatient knowing that I broke the latest release so I went ahead and implemented the fix. Sorry if you've already started looking at this.
Test Plan:
I used https://github.com/timmywil/react-native-async-storage-1.3.1, kindly provided by @timmywil, for testing.
Migration Plan:
Even though
react-native linkwill be able to link the new.podspec, it won't clean up existing entries. Please find your Podfile, and make the following changes: